I don't think that all unit tests pass in Java8. I fixed a couple of test cases but I'm pretty sure some JDBC tests still fail because of the new default methods added to the JDBC interface which are not overriden in Avatica and Drill: https://issues.apache.org/jira/browse/DRILL-4333
I don't have strong opinions against or for dropping Java 7 support but as far as I know, Oracle still support Java7 until 2022 for paying customers. Redhat on the other end will end openjdk 7 support in June 2018. I guess it's more of a matter of whatever users are still using or not (and looking at Hortonworks/Cloudera/MapR, they still support Java7). As for the mysterious issue in Eclipse regarding Java8, it's more of a maven/eclipse integration issue than a Drill issue. The corresponding Eclipse bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=432992 and I work around it by adding the correct tools.jar in the classpath to match the JRE version. Laurent On Mon, Nov 28, 2016 at 11:12 AM, Abhishek Girish <[email protected] > wrote: > One of the reasons I remember not supporting Java 8 were unresolved unit > test failures. I'm not sure if they still occur - did you get a chance to > try a build with unit tests turned on? > > On Mon, Nov 28, 2016 at 10:50 AM, Paul Rogers <[email protected]> > wrote: > > > Hi All, > > > > Drill still builds with Java 7. Many of us have upgraded to Java 8. (Java > > 7 reached end-of-life in April of 2015.) > > > > For the most part, it works fine to have Java 8 as the default JDK, while > > Drill builds with Java 7. However, it becomes a real problem when trying > to > > use Eclipse to run unit tests, especially those that include JMockit. > > > > When I used Java 8 for Eclipse, but Java 7 for the Drill build, unit > tests > > fail with mysterious errors. Forcing Eclipse to use Java 7 (or forcing > > Drill to use Java 8) is the workaround. (Something about the way the > JUnit > > test runner works.) > > > > Have we considered upgrading Drill’s build to Java 8? > > > > Does Drill or Apache have obligations to support Java 7 even though > Oracle > > no longer does so? > > > > The workaround is to muck about until the Java versions match. A hassle, > > but it works. It does, however take time that could be better spent on > > other things. > > > > Thanks, > > > > - Paul >
