Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r89902578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +224,100 @@ public void connect(Properties props) throws
RpcException {
connect(null, props);
}
+ /**
+ * Populates the endpointlist with drillbits information provided in the
connection string by client.
+ * For direct connection we can have connection string with drillbit
property as below:
+ * <dl>
+ * <dt>drillbit=ip</dt>
+ * <dd>use the ip specified as the Foreman ip with default port in
config file</dd>
+ * <dt>drillbit=ip:port</dt>
+ * <dd>use the ip and port specified as the Foreman ip and port</dd>
+ * <dt>drillbit=ip1:port1,ip2:port2,...</dt>
+ * <dd>randomly select the ip and port pair from the specified list as
the Foreman ip and port.</dd>
+ * </dl>
+ *
+ * @param drillbits string with drillbit value provided in connection
string
+ * @param defaultUserPort string with default userport of drillbit
specified in config file
+ * @return list of drillbit endpoints parsed from connection string
+ * @throws InvalidConnectionInfoException if the connection string has
invalid or no drillbit information
+ */
+ static List<DrillbitEndpoint> parseAndVerifyEndpoints(String drillbits,
String defaultUserPort)
+ throws InvalidConnectionInfoException {
+ // If no drillbits is provided then throw exception
+ drillbits = drillbits.trim();
+ if (drillbits.isEmpty()) {
+ throw new InvalidConnectionInfoException("No drillbit information
specified in the connection string");
+ }
+
+ ArrayList<DrillbitEndpoint> endpointList = new ArrayList<>();
--- End diff --
final List\<DrillbitEndpoint\> ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
