Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r91509351
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/compile/MergeAdapter.java ---
    @@ -253,7 +257,13 @@ public static MergedClassResult getMergedClass(final 
ClassSet set, final byte[]
           }
     
           // enable when you want all the generated merged class files to also 
be written to disk.
    -//      Files.write(outputClass, new 
File(String.format("/src/scratch/drill-generated-classes/%s-output.class", 
set.generated.dot)));
    +//      try {
    --- End diff --
    
    1. May also to add some configuration option to avoid uncommenting?
    2. May be to avoid hard-coding "/tmp/scratch/drill-generated-classes" and 
make it configurable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to