Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/684
Golden copies are needed only for tests that, today, do their "testing" by
dumping generated code to stdout. Such tests do absolutely nothing (other than
detect crashes) when run under Maven. The golden copy assures that such
low-level tests are verified.
Other tests verify results by executing code. No need to save a golden copy
of code for those.
Yes, when code gen changes, the golden copies have to be recaptured.
However, how else can we verify that the new changes do what we expect if we
don't actually examine them and save the desired final state? How else do we
detect unexpected changes to generated code? (For example, if we generated a
bunch of unneeded boilerplate, we'd not detect that in an execution test.)
This test is also going to be a way to verify DRILL-5052: capture code
using the current code gen technique, then verify against the code path
described in DRILL-5052. The two paths should be identical except for an extra
"extends" in the code from DRILL-5052.
Is it worth testing such cases or is it OK to simply trust that the
generated code is probably OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
