Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93125431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/AbstractClassCompiler.java
---
@@ -74,9 +76,10 @@ protected String prefixLineNumbers(String code) {
return out.toString();
}
- protected abstract byte[][] getByteCode(ClassNames className, String
sourcecode)
+ protected abstract byte[][] getByteCode(final ClassNames className,
final String sourcecode)
throws CompileException, IOException, ClassNotFoundException,
ClassTransformationException;
-
+ public abstract Map<String,byte[]> compile(final ClassNames className,
final String sourceCode)
--- End diff --
can you please add comment to explain the change (the return type is
changed)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
