Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/706#discussion_r94995057
  
    --- Diff: exec/java-exec/src/main/codegen/templates/NewValueFunctions.java 
---
    @@ -17,8 +17,14 @@
      */
     <@pp.dropOutputFile />
     
    +<#macro reassignHolder>
    +        previous.buffer = buf.reallocIfNeeded(length);
    +        previous.buffer.setBytes(0, in.buffer, in.start, length);
    +        previous.end = length;
    +</#macro>
     
    -<@pp.changeOutputFile 
name="/org/apache/drill/exec/expr/fn/impl/GNewValueFunctions.java" />
    +
    +<@pp.changeOutputFile 
name="/org/apache/drill/exeBasec/expr/fn/impl/GNewValueFunctions.java" />
    --- End diff --
    
    Is this the correct output destination ?  I get an error in my IDE:
    The declared package "org.apache.drill.exec.expr.fn.impl" does not match 
the expected package "org.apache.drill.exeBasec.expr.fn.impl"      
GNewValueFunctions.java 
/drill-java-exec/target/generated-sources/org/apache/drill/exeBasec/expr/fn/impl



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to