Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95047869
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java
---
@@ -40,12 +39,12 @@
private final String url;
protected final List<MockGroupScanPOP.MockScanEntry> readEntries;
-// private final OperatorCost cost;
-// private final Size size;
- private LinkedList<MockGroupScanPOP.MockScanEntry>[] mappings;
+ private boolean extended;
@JsonCreator
- public MockSubScanPOP(@JsonProperty("url") String url,
@JsonProperty("entries") List<MockGroupScanPOP.MockScanEntry> readEntries) {
+ public MockSubScanPOP(@JsonProperty("url") String url,
--- End diff --
Can we overload the constructor instead ? That way for new parameters
default value will be initialized and we don't have to change the older usage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
