Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95064583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java
---
@@ -40,12 +39,12 @@
private final String url;
protected final List<MockGroupScanPOP.MockScanEntry> readEntries;
-// private final OperatorCost cost;
-// private final Size size;
- private LinkedList<MockGroupScanPOP.MockScanEntry>[] mappings;
+ private boolean extended;
@JsonCreator
- public MockSubScanPOP(@JsonProperty("url") String url,
@JsonProperty("entries") List<MockGroupScanPOP.MockScanEntry> readEntries) {
+ public MockSubScanPOP(@JsonProperty("url") String url,
--- End diff --
This is a constructor used for Jackson serialization. Not sure that Jackson
is smart enough to choose among a set of constructors. As it turns out, Jackson
will provide a null or default values for parameters that don't' appear in the
serialized format. This is why the parameter is a `Boolean`: Jackson will fill
in a null value for older physical plans that are non-extended.
Added comments to explain this (admittedly obscure) usage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
