Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95469122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config, OptionManager
optionManager) {
// A key advantage of this method is that the code can be
// saved and debugged, if needed.
- saveCode(code, name);
+ if (cg.persistCode()) {
--- End diff --
Method names changed to `saveCodeForDebugging` and `isCodeToBeSaved`. More
of a mouthful, but hopefully this will be clearer -- also clearer that code is
saved only for the purpose of debugging (not, for example, as a code cache that
spans Drillbit runs, etc.) I'd kind of hoped the Javadoc would explain all
that...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
