Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/723#discussion_r97908127
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -74,12 +82,17 @@ protected void loadDictionaryIfExists(final
ColumnReader<?> parentStatus,
handleAndThrowException(e, "Error Reading dictionary page.");
}
// parent constructor may call this method before the thread pool is
set.
--- End diff --
Why not ensure parent calls the c'tor with pool != null?
That way all variables can be final and non-null, the `offer(...)` is only
done once in the c'tor, and the internal classes can directly access the
`pageQueue`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
