Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385541
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final String[] columns) {
sb.append("</tr>\n");
}
+ /**
+ * Representation of a millisecond duration in a short readable text
+ * @param millis Duration in milliseconds
+ * @return Human-Readable Duration Time
+ */
+ public String shortDurationFormat(long millis) {
--- End diff --
Used elsewhere? If so, consider making static (so we don't need an
instance.) If only used here, consider making private.
In fact, maybe move this out to a utility class. This logic can be used
anywhere we want to display a duration such as in logs, in tests, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
