Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r99454180
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -178,22 +192,41 @@ private String functionReplacement(FunctionCall
functionCall) {
}
/**
- * Find the Drill function implementation that matches the name, arg
types and return type.
- * If exact function implementation was not found,
- * loads all missing remote functions and tries to find Drill
implementation one more time.
+ * Finds the Drill function implementation that matches the name, arg
types and return type.
+ *
+ * @param name function name
+ * @param argTypes input parameters types
+ * @param returnType function return type
+ * @return exactly matching function holder
--- End diff --
Thanks for adding the Javadoc! Very helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
