Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/752#discussion_r102320948
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java
 ---
    @@ -89,14 +85,30 @@ public boolean supportsRead() {
         return true;
       }
     
    -//  public static class ImplicitTable extends DynamicDrillTable {
    -//
    -//    public ImplicitTable(StoragePlugin plugin, String storageEngineName,
    -//        Object selection) {
    -//      super(plugin, storageEngineName, selection);
    -//    }
    -//
    -//  }
    +  /**
    +   * Resolves table names within the mock data source. Tables can be of 
two forms:
    +   * <p>
    +   * <tt><name>_<n><unit></tt>
    +   * <p>
    +   * Where the "name" can be anything, "n" is the number of rows, and 
"unit" is
    +   * the units for the row count: non, K (thousand) or M (million).
    +   * <p>
    +   * The above form generates a table directly with no other information 
needed.
    +   * Column names must be provided, and must be of the form:
    +   * <p>
    +   * <tt><name>_<type><size></tt>
    +   * <p>
    +   * Where the name can be anything, the type must be i (integer), d 
(double)
    +   * or s (string, AKA VarChar). The length is needed only for string 
fields.
    --- End diff --
    
    how about boolean (b) as a type ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to