Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/749#discussion_r102726321
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
 ---
    @@ -73,6 +72,7 @@
       private static final long DEFAULT_BATCH_LENGTH = 256 * 1024 * 
NUMBER_OF_VECTORS; // 256kb
       private static final long DEFAULT_BATCH_LENGTH_IN_BITS = 
DEFAULT_BATCH_LENGTH * 8; // 256kb
       private static final char DEFAULT_RECORDS_TO_READ_IF_NOT_FIXED_WIDTH = 
32*1024;
    --- End diff --
    
    while we are at it, I would probably rename 
DEFAULT_RECORDS_TO_READ_IF_NOT_FIXED_WIDTH to 
DEFAULT_RECORDS_TO_READ_VARIABLE_WIDTH


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to