Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102841504
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default is DEFAULT_SCAN_THREADS
put(ExecConstants.SCAN_THREADPOOL_SIZE, 4);
+
+ // Define a useful root location for the ZK persistent
+ // storage. Profiles will go here when running in distributed
+ // mode.
+
+
put(ZookeeperPersistentStoreProvider.DRILL_EXEC_SYS_STORE_PROVIDER_ZK_BLOBROOT,
"/tmp/drill/log");
}
};
public static final String DEFAULT_BIT_NAME = "drillbit";
private DrillConfig config;
- private Map<String,Drillbit> bits = new HashMap<>();
+ private Map<String, Drillbit> bits = new HashMap<>();
private Drillbit defaultDrillbit;
private BufferAllocator allocator;
private boolean ownsZK;
private ZookeeperHelper zkHelper;
private RemoteServiceSet serviceSet;
- private String dfsTestTmpSchemaLocation;
+ private File dfsTestTempDir;
protected List<ClientFixture> clients = new ArrayList<>();
+ private boolean usesZk;
+ private boolean preserveLocalFiles;
+ private boolean isLocal;
+
+ /**
+ * Temporary directories created for this test cluster.
+ * Each is removed when closing the cluster.
+ */
+
+ private List<File> tempDirs = new ArrayList<>();
+
+ ClusterFixture(FixtureBuilder builder) {
+
+ String zkConnect = configureZk(builder);
+ try {
+ createConfig(builder, zkConnect);
--- End diff --
Good catch. Moved creating the allocator earlier.
The `getServiceSetWithFullCache` thing is existing code. Only used in the
original `BaseTestQuery` and here (which I adapted from `BaseTestQuery`.) Went
ahead and cleaned up the signature in both places.
Not only that, but `getServiceSetWithFullCache()` is the same as
`getLocalServiceSet()`. Probably some legacy reason the "cache" version
existed. Since none of us know that reason, went ahead and removed the "cache"
version.
Also removed the config option that enable the (no op) cached version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
