Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/761#discussion_r103067062
  
    --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java 
---
    @@ -238,6 +238,25 @@ public boolean copyFromSafe(int fromIndex, int 
thisIndex, ${minor.class}Vector f
         return true;
       }
     
    +  @Override
    +  public int getAllocatedByteCount() {
    +    return offsetVector.getAllocatedByteCount() + 
super.getAllocatedByteCount();
    --- End diff --
    
    Why don't the other getAllocatedByteCount() methods add the "super" ?  Is 
it because their supers do not allocate ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to