Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/765#discussion_r103597790
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashPrelUtil.java
---
@@ -89,14 +91,15 @@ public LogicalExpression createCall(String funcName,
List<LogicalExpression> inp
*/
public static <T> T createHashExpression(
List<T> inputExprs,
+ T seed,
HashExpressionCreatorHelper<T> helper,
boolean hashAsDouble) {
assert inputExprs.size() > 0;
final String functionName = hashAsDouble ? HASH32_DOUBLE_FUNCTION_NAME
: HASH32_FUNCTION_NAME;
- T func = helper.createCall(functionName,
ImmutableList.of(inputExprs.get(0)));
+ T func = helper.createCall(functionName,
ImmutableList.of(inputExprs.get(0), seed ));
--- End diff --
Could you confirm if all the function names in function template and data
types that are covered in the Hash32Functions are also present in the
Hash32FunctionsWithSeed ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
