Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/795#discussion_r108051823
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java
---
@@ -119,6 +127,74 @@ public SchemaPlus createRootSchema(SchemaConfig
schemaConfig) {
}
}
+
+ public SchemaPlus createPartialRootSchema(final String userName, final
SchemaConfigInfoProvider provider,
+ final String storage) {
+ final String schemaUser = isImpersonationEnabled ? userName :
ImpersonationUtil.getProcessUserName();
+ final SchemaConfig schemaConfig = SchemaConfig.newBuilder(schemaUser,
provider).build();
+ final SchemaPlus rootSchema =
SimpleCalciteSchema.createRootSchema(false);
+ Set<String> storageSet = Sets.newHashSet();
+ storageSet.add(storage);
+ addNewStoragesToRootSchema(schemaConfig, rootSchema, storageSet);
+ schemaTreesToClose.add(rootSchema);
--- End diff --
There is quite a bit of plumbing here to get right -- for each new schema
added. Please factor out the common code into a (private) implementation
method. Else, we'll be chasing bugs forever as people modify one copy but miss
the others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
