Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/801#discussion_r108493691
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -278,7 +281,7 @@ public void setup(HashAggregate hashAggrConfig,
HashTableConfig htConfig, Fragme
}
@Override
- public AggOutcome doWork() {
+ public AggOutcome doWork() throws SchemaChangeException {
--- End diff --
`doWork()` is used elsewhere as well. e.g. StreamingAggregator. Would it
make sense to address other `doWork()` s in this PR. Better yet factor out
another interface which the HashAggregator/StreamingAggregator implement - this
would contain `public AggOutcome doWork() throws SchemaChangeException`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
