Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/802#discussion_r108821978
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseScanSpec.java
---
@@ -76,6 +78,10 @@ public String getTableName() {
return stopRow == null ? HConstants.EMPTY_START_ROW : stopRow;
}
+ public long getRowCount() { return rowCount; }
+
+ public void setRowCount(long numRowCount) { rowCount = numRowCount; }
--- End diff --
Should the ScanSpec be mutable since it serves a specification? I looked at
other ScanSpecs but none seem to set ScanSpec members. Maybe all the members
should be final and initialized via the constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
