Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r109960614
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java
---
@@ -208,8 +207,12 @@ void process(SaslResponseContext<S, T> context) throws
Exception {
handleSuccess(context, challenge, saslServer);
} else {
- logger.info("Failed to authenticate client from {}",
context.remoteAddress);
- throw new SaslException("Client allegedly succeeded
authentication, but server did not. Suspicious?");
+ final S connection = context.connection;
+ logger.info("Failed to authenticate client from {} with encryption
context:{}",
+ connection.getRemoteAddress().toString(),
--- End diff --
Leave the `context.remoteAddress` as is (here and below); I happened to
notice`.toString()` is expensive.
nit: why evaluate `getEncryptionString` every time, cache that too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
