Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r111646955
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
@@ -243,4 +247,43 @@ public SaslMessage process(SaslChallengeContext
context) throws Exception {
}
}
}
+
+ private static void handleSuccess(SaslChallengeContext context) throws
SaslException {
+ final ClientConnection connection = context.connection;
+ final SaslClient saslClient = connection.getSaslClient();
+
+ if (connection.isEncrypted()) {
+ try {
+ // Check if connection was marked for being secure then verify for
negotiated QOP value for
+ // correctness.
+ final String negotiatedQOP =
saslClient.getNegotiatedProperty(Sasl.QOP).toString();
+ assert
(negotiatedQOP.equals(SaslProperties.QualityOfProtection.PRIVACY.getSaslQop()));
+
+ // Update the rawWrapChunkSize with the negotiated buffer size
since we cannot call encode with more than
+ // negotiated size of buffer.
+ final int negotiatedRawSendSize = Integer.parseInt(saslClient
+
.getNegotiatedProperty(SaslProperties.WRAP_RAW_SEND_SIZE)
+ .toString());
+ if(negotiatedRawSendSize <= 0) {
+ throw new SaslException(String.format("Negotiated rawSendSize:
%d is invalid. Please check the configured " +
+ "value of sasl.encryption.encodesize. It might be configured
to a very small value.",
+ negotiatedRawSendSize));
+ }
+ connection.setRawWrapSendSize(negotiatedRawSendSize);
+ connection.addSecurityHandlers();
+ } catch (Exception e) {
+ throw new SaslException(String.format("Unexpected failure while
retrieving negotiated property values (%s)",
+ e.getMessage()), e);
+ }
+ } else {
+ // Encryption is not required hence we don't need to hold on to
saslClient object.
+ if (saslClient != null) {
--- End diff --
Considering these objects are per connection and have security contexts, I
would prefer to get rid of these objects in cases when only Authentication is
used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
