Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113802524
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -394,31 +414,37 @@ public RelDataType inferReturnType(SqlOperatorBinding
opBinding) {
}
private static class DrillConcatSqlReturnTypeInference implements
SqlReturnTypeInference {
- private static final DrillConcatSqlReturnTypeInference INSTANCE = new
DrillConcatSqlReturnTypeInference();
--- End diff --
For the various SqlReturnTypeInference, seems the same logic is applied
here and in DrillConcatFuncHolder. If we choose not to expand "FunctionScope"
and model it as ReturnTypeInference, then we probably will be able to abstract
and share the common code. That would save effort in the future to maintain two
almost identical pieces of codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
