Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113834757
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
---
@@ -106,15 +106,21 @@
DECIMAL_ADD_SCALE,
DECIMAL_SET_SCALE,
DECIMAL_ZERO_SCALE,
- SC_BOOLEAN_OPERATOR
+ SC_BOOLEAN_OPERATOR,
--- End diff --
At the very least, call it something other than "scope." The word "scope"
has a very precise meaning in CS: it is the set of symbols visible to an
execution context. I must admit I'm struggling to see how, say, "CONCAT" fits
this. Thanks to Jinfeng for explaining that FunctionScope has evolve to mean
something like "FunctionHints"...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
