Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r114828323 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } } -status_t DrillClientImpl::readMsg(ByteBuf_t _buf, - AllocatedBufferPtr* allocatedBuffer, +/* + * Decode the length of the message from bufWithLen and then read entire message from the socket. + * Parameters: + * bufWithLen - in param - buffer containing the bytes which has length of the RPC message/encrypted chunk + * bufferWithLenBytes - out param - buffer pointer which points to memory allocated in this function and has the --- End diff -- 'bufferWithLenBytes' this name is confusing given that there is already a 'bufWithLen'. How about something like 'bufWithRPCMsg'?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---