Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r117412544
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -364,7 +395,41 @@ connectionStatus_t DrillClientImpl::recvHandshake(){
return CONN_SUCCESS;
}
-void DrillClientImpl::handleHandshake(ByteBuf_t _buf,
+/*
+ * Read bytesToRead length data bytes from socket into inBuf. It handles
EINTR error
+ * occurred during read_some sys call and does a retry on that.
+ *
+ * Parameters:
+ * inBuf - out param - Pointer to buffer to read data into
from socket.
+ * bytesToRead - in param - Length of data bytes to read from
socket.
+ * errorCode - out param - Error code set by boost.
+ */
+void DrillClientImpl::doReadFromSocket(ByteBuf_t inBuf, size_t bytesToRead,
+ boost::system::error_code&
errorCode) {
+
+ // Check if bytesToRead is zero
+ if(0 == bytesToRead) {
--- End diff --
Does a NULL inBuf have to be handled ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
