Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118057123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -219,12 +232,43 @@ public void sessionDestroyed(HttpSessionEvent se) {
securityHandler.logout(sessionAuth);
session.removeAttribute(SessionAuthentication.__J_AUTHENTICATED);
}
+
+ // Clear all the custom attributes set as part of session
+ clearSessionCustomAttributes(session);
}
});
return new SessionHandler(sessionManager);
}
+ private void clearSessionCustomAttributes(HttpSession session) {
--- End diff --
How about encapsulating all the resources in one class (`DrillWebSession`)?
+ Only that instance would be an attribute on a http session.
+ This logic could be captured in `DrillWebSession#close` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
