Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118592786
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
 ---
    @@ -133,6 +133,9 @@
          the need to turn off join optimization may go away.
        */
       public static final BooleanValidator JOIN_OPTIMIZATION = new 
BooleanValidator("planner.enable_join_optimization", true);
    +  // for testing purpose
    --- End diff --
    
    @VisibleForTesting annotates methods; but this is a session option. 
    Also (hidden) is the possibility that this option may be used in production 
in case some query yields a single phase hashagg but still has too much data to 
handle.    


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to