Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/808#discussion_r118619667
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/BaseAllocator.java
---
@@ -793,20 +797,20 @@ public static boolean isDebug() {
return DEBUG;
}
- /**
- * Disk I/O buffer used for all reads and writes of DrillBufs.
- */
-
- private byte ioBuffer[];
-
public byte[] getIOBuffer() {
if (ioBuffer == null) {
+ // Length chosen to the smallest size that maximizes
+ // disk I/O performance. Smaller sizes slow I/O. Larger
+ // sizes provide no increase in performance.
+ // Revisit from time to time.
--- End diff --
Not likely to revisit, when the hard coded size is so deep in the code.
Maybe define it at the top of the file (or better - a configurable boot option)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
