Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/846#discussion_r119223453
--- Diff:
exec/java-exec/src/main/java/org/apache/parquet/hadoop/ParquetColumnChunkPageWriteStore.java
---
@@ -0,0 +1,269 @@
+/*
--- End diff --
Compared this file to the Parquet original (thanks for providing the file
name) using [this tool](https://www.diffchecker.com/diff), referencing the
diagram [here](https://parquet.apache.org/documentation/latest/). The changes
made in the Drill copy seem reasonable.
I do have questions, however, about the approach to writing. (See below.)
Seems overly memory intensive. But, this is an issue with the Parquet original,
not about this "port" of the file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
