Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r119747147
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -285,8 +648,18 @@ public AggOutcome doWork() {
// In the future HashAggregate may also need to perform some actions
conditionally
// in the outer try block.
+ assert ! handlingSpills || currentIndex < Integer.MAX_VALUE;
+
outside:
while (true) {
+
+ // This would be called only once - after actual data arrives on
incoming
+ if ( schema == null && incoming.getRecordCount() > 0 ) {
+ this.schema = incoming.getSchema();
+ // Calculate the number of partitions based on actual incoming
data
+ delayedSetup();
+ }
+
--- End diff --
Annotate history points to @amansinha100 as the creator .... And the trace
level logging is already used heavily for "normal monitoring" (e.g., number of
partitions chosen, size estimates). Need some new levels below trace, which
unfortunately cannot be created in LogBack .....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
