Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r122310373
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -154,7 +152,7 @@
private int cycleNum = 0; // primary, secondary, tertiary, etc.
private int originalPartition = -1; // the partition a secondary reads
from
- private class SpilledPartition { public int spilledBatches; public
String spillFile /* Path filePath */; int cycleNum; int origPartn; int
prevOrigPartn; }
+ private class SpilledPartition { public int spilledBatches; public
String spillFile; int cycleNum; int origPartn; int prevOrigPartn; }
--- End diff --
`private static class` since you don't have any methods and so have no use
for the "inner this" pointer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
