Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123303854
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -422,6 +507,9 @@ public ResultSet getGeneratedKeys() throws SQLException
{
public int executeUpdate(String sql, int autoGeneratedKeys) throws
SQLException {
throwIfClosed();
try {
+ if (timeoutTrigger != null) {
--- End diff --
so the trigger is created, but if super.executeUpdate takes more than
queryTimeout seconds, the method is not interrupted. I don't believe this is
conform to JDBC spec, or somehow useful to the end-user (if query takes 2min
but timeout is 60s, exception should be thrown after 60s, not 120s...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
