Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/863#discussion_r124953949
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -78,4 +81,71 @@ public void testToDateForTimeStamp() throws Exception {
.build()
.run();
}
+
+ @Test // DRILL-4970
+ public void testCastNegativeFloatToInt() throws Exception {
+ try {
+ test("create table dfs_test.tmp.table_with_float as\n" +
--- End diff --
Also, would be great if this can be unit tested directly, without a
Drillbit. Use the `SubOperatorTest` framework if needed. But, since these are
simple math functions, a basic JUnit test should be fine. Allows testing many
more values without the complexity of a query.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
