Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/868#discussion_r126828037
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
---
@@ -35,7 +36,7 @@
public class OptionValue implements Comparable<OptionValue> {
public enum OptionType {
- BOOT, SYSTEM, SESSION, QUERY
+ BOOT, DEFAULT, SYSTEM, SESSION, QUERY
--- End diff --
Actually, can't we reuse BOOT instead of adding DEFAULT?
As far as I can tell, the BOOT choice is used only in the options iterator
(DrillConfigIterator) to prepare a list for UI display. Since our defaults are
not BOOT options, can we just reuse that existing enum rather than having a
(config option for BOOT use vs. config option for DEFAULT use) confusion?
And, of course, this is a vestige of a deeper problem: the Type means "kind
of option: boot option, system-only option, or session option" to some code,
while it means "scope in which the option is actually set" to other code. Quite
a muddle!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
