Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127077314
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
@@ -100,10 +102,12 @@ private PriorityQueueCopier
newCopier(VectorAccessible batch) {
* @param batchGroupList
* @param outputContainer
* @param targetRecordCount
+ * @param allocHelper
* @return
*/
- public BatchMerger startMerge(BatchSchema schema, List<? extends
BatchGroup> batchGroupList, VectorContainer outputContainer, int
targetRecordCount) {
- return new BatchMerger(this, schema, batchGroupList, outputContainer,
targetRecordCount);
+ public BatchMerger startMerge(BatchSchema schema, List<? extends
BatchGroup> batchGroupList,
--- End diff --
How about creating another **startMerge(...)** without the last
**allocHelper** parameter, which would then call **BatchMerger(......., null)**
; this new overloaded one would be used in places like TestCopier.java, instead
of adding a last null parameter there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
