Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127358527
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java ---
@@ -26,14 +26,16 @@ public static void allocate(ValueVector v, int
valueCount, int bytesPerValue) {
allocate(v, valueCount, bytesPerValue, 5);
}
- public static void allocatePrecomputedChildCount(ValueVector v, int
valueCount, int bytesPerValue, int childValCount){
- if(v instanceof FixedWidthVector) {
+ public static void allocatePrecomputedChildCount(ValueVector v, int
valueCount, int bytesPerValue, int childValCount) {
--- End diff --
Discouraged: single letter parameter/field names. Even **"vv"** would be
easier to search, if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
