Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/871#discussion_r127536980
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -401,7 +398,7 @@ private void delayedSetup() {
} else { // two phase
// Adjust down the number of partitions if needed - when the memory
available can not hold as
// many batches (configurable option), plus overhead (e.g. hash
table, links, hash values))
- while ( numPartitions * ( estMaxBatchSize * minBatchesPerPartition +
8 * 1024 * 1024) > memAvail ) {
+ while ( numPartitions * ( estMaxBatchSize * minBatchesPerPartition +
2 * 1024 * 1024) > memAvail ) {
--- End diff --
Why 2 MB? Should this a constant so the name gives a hint?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
