Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/922
-1
This seems like a good idea. But, I don't think this is the way we should
go for reasons identified in the JIRA.
For one, we count on the user to provide a parameter to describe their
system memory to work around a problem where the user provides another
parameter that is not consistent with their system memory. Why would the user
set one correctly but the other wrong?
This change overly complicates the shell scripts. This change conflicts
with the way that YARN, Warden and other tools allocate memory.
A better solution would be:
1. When the Drillbit starts, obtain (from the system) the available memory.
(Or, if running under YARN, obtain the YARN-allocated memory from an env var.
Same for Warden or Mesos or...)
2. Do the math on the memory allocations.
3. If the memory is too large, write a warning to the log file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
