Paul Rogers created DRILL-5746:
----------------------------------
Summary: Pcap PR manually edited Protobuf files, values lost on
next build
Key: DRILL-5746
URL: https://issues.apache.org/jira/browse/DRILL-5746
Project: Apache Drill
Issue Type: Bug
Affects Versions: 1.10.0
Reporter: Paul Rogers
Assignee: Paul Rogers
Fix For: 1.12.0
Drill recently accepted the pcap format plugin. As part of that work, the
author added a new operator type, {{PCAP_SUB_SCAN_VALUE}}.
But, apparently this was done by editing the generated Protobuf files to add
the values, rather than modifying the protobuf definitions and rebuilding the
generated files. The result is, on the next build of the Protobuf sources, the
following compile error appears:
{code}
[ERROR]
/Users/paulrogers/git/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java:[80,41]
error: cannot find symbol
[ERROR] symbol: variable PCAP_SUB_SCAN_VALUE
[ERROR] location: class CoreOperatorType
{code}
The solution is to properly edit the Protobuf definitions with the required
symbol.
In addition, the name {{PCAP_SUB_SCAN_VALUE}} does not follow Drill's naming
conventions. It should be: {{PCAP_SUB_SCAN}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
