Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r136657343
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StatusResources.java
---
@@ -50,75 +53,124 @@
public class StatusResources {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(StatusResources.class);
+ public static final String PATH_STATUS_JSON = "/status.json";
+ public static final String PATH_STATUS = "/status";
+ public static final String PATH_OPTIONS_JSON = "/options.json";
+ public static final String PATH_INTERNAL_OPTIONS_JSON =
"/internal_options.json";
+ public static final String PATH_OPTIONS = "/options";
+ public static final String PATH_INTERNAL_OPTIONS = "/internal_options";
--- End diff --
Nice improvement to externalize constants. Perhaps the constants can show
the relationships between paths. For example:
```
public static final String REST_API_SUFFIX = ".json";
public static final String PATH_STATUS_UI = "/status";
public static final String PATH_STATUS_API = PATH_STATUS_UI +
REST_API_SUFFIX;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
