Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/934#discussion_r137938397
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentStatusReporter.java
 ---
    @@ -113,4 +120,14 @@ void fail(final UserException ex) {
         sendStatus(status);
       }
     
    +  @Override
    +  public void close()
    +  {
    +    final ControlTunnel tunnel = this.tunnel.getAndSet(null);
    +    if (tunnel != null) {
    +      logger.debug("Closing {}", this);
    --- End diff --
    
    We say we are closing the tunnel, but then don't do anything. Perhaps a 
comment to explain how this works?


---

Reply via email to