Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r138205470
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java ---
@@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception {
test("ALTER session SET `%s` = %d;", SLICE_TARGET,
ExecConstants.SLICE_TARGET_DEFAULT);
testBuilder()
- .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND
type = 'SESSION'", SLICE_TARGET)
+ .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND
optionScope = 'SESSION'", SLICE_TARGET)
--- End diff --
Taking a note of what we discussed offline.
Course of action is to just change the name for **type** since it is a bad
name, and the semantics of **type** have been ill-defined. So no one could have
relied on the values returned to them in the past anyway. I am changing the
name to **accessibleScopes**.
---
