Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138499857
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -54,11 +56,13 @@
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
+import org.junit.experimental.categories.Category;
import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@RunWith(Parameterized.class)
+@Category({SecondaryTest.class, ParquetTest.class})
--- End diff --
To me the main distinction between smoke and secondary tests should be
runtime. It's hard in my mind to distinguish based on importance, because the
relevance of a test depends on the change being done. And you would end up
running all the tests before finishing your change no matter what. The workflow
I had in mind was the following:
1. Make a change
1. Run Fast tests for my category of interest (e.g. **OperatorTest**).
Oops there's a failure
1. Fix the failure
1. Run Fast tests for category **OperatorTest** again. Oops another
failure
1. Fix the failure
1. Run Fast tests for category **OperatorTest** again. Yay they pass
1. Run all the tests
1. Done
Let me know what you think.
---
