Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/953#discussion_r140644680
--- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
@@ -37,7 +37,15 @@
<strong>No running queries.</strong>
</div>
</#if>
- <h3>Completed Queries</h3>
+ <table width="100%">
+ <tr>
+ <td><h3>Completed Queries</h3></td>
+ <td align="right">
+ <form action="/profiles" method="get"><span title="Max number of
profiles to list"># Profiles: </span>
+ <input type="text" size="7" name="max" value="20">
+ <input type="submit" value="Fetch">
+ </form></td>
+ </tr></table>
--- End diff --
Good idea. Some thoughts:
1. Do we need a table to display one line?
2. The value of the input is always 20. But, isn't our default something
like 100? And, if I choose to display 50, shouldn't that be the default when
the page is redisplayed?
3. This change will render a UI something like this:
```
Completed Queries
Completed Queries # Profiles [20 ] [Fetch]
<table of profiles>
```
This seems a bit busy. Can we do it like this:
```
Completed Queries Show [ 20] [Go]
```
That is, with the form right-aligned on the same line as the title.
Better, can we implement paging? Rather than display 200 or so profiles
(which is too much for humans to digest), show 10 or 20, and provide the usual
buttons to display multiple pages.
Doing it this way requires a filter on top of the fetch logic, but should
not be too hard. Might be inefficient to fetch, say, 200 profiles, and keep
only the last 20, but that is our internal problem, not the user's problem. We
can optimize that logic later.
---
