Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621499 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.rpc; + +import com.google.protobuf.MessageLite; +import io.netty.buffer.ByteBuf; +import io.netty.channel.Channel; +import io.netty.channel.ChannelFuture; +import io.netty.util.concurrent.Future; +import io.netty.util.concurrent.GenericFutureListener; +import org.apache.drill.common.exceptions.DrillException; +import org.slf4j.Logger; + +import java.net.SocketAddress; +import java.util.concurrent.TimeUnit; + +/** + * @param <CC> Client Connection Listener + * @param <HS> Outbound handshake message type + * @param <HR> Inbound handshake message type + * @param <BC> BasicClient type + * <p> + * Implements a wrapper class that allows a client connection to associate different behaviours after + * establishing a connection with the server. The client can choose to send an application handshake, or + * in the case of SSL, wait for a SSL handshake completion and then send an application handshake. + */ + +public class ConnectionMultiListener<CC extends ClientConnection, HS extends MessageLite, HR extends MessageLite, BC extends BasicClient> { --- End diff -- I am seeing lots of unchecked warning for this file. Please fix those.
---