Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/975#discussion_r143265321
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
@@ -109,11 +110,14 @@ public HBaseRecordReader(Connection connection,
HBaseSubScan.HBaseSubScanSpec su
byte[] family = root.getPath().getBytes();
transformed.add(SchemaPath.getSimplePath(root.getPath()));
PathSegment child = root.getChild();
- if (child != null && child.isNamed()) {
- byte[] qualifier = child.getNameSegment().getPath().getBytes();
- hbaseScan.addColumn(family, qualifier);
- } else {
- hbaseScan.addFamily(family);
+ if (!completeFamilies.contains(new String(family))) {
+ if (child != null && child.isNamed()) {
+ byte[] qualifier = child.getNameSegment().getPath().getBytes();
--- End diff --
This assumes UTF-8 encoding for the name. Can we be sure that HBase always
uses UTF-8 for its encoding? Or, does HBase only support ASCII names so that we
need only the ASCII subset of UTF-8? What happens if the user puts a non-ASCII
character into the name in this case?
---
