Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/968#discussion_r143714717
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java
 ---
    @@ -150,6 +162,40 @@ public boolean load(RecordBatchDef def, DrillBuf buf) 
throws SchemaChangeExcepti
         return schemaChanged;
       }
     
    +  private boolean checkMapSchema(Collection<MaterializedField> 
currentChildren,
    --- End diff --
    
    May be we can rename method? At least for me under `checkMapSchema` is not 
quite obvious that we will be comparing two schemas and return true if two maps 
are the same (comments inside of the method were helpful though).


---

Reply via email to