Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145519174
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
    @@ -213,7 +204,7 @@ private void configureZk(FixtureBuilder builder) {
         }
       }
     
    -  private void createConfig(FixtureBuilder builder) throws Exception {
    +  private void createConfig() throws Exception {
    --- End diff --
    
    There are actually three ZK cases:
    
    * Does not use ZK at all.
    * Uses ZK, but it is local (mini ZK started within test JDK)
    * Uses ZK, but ZK is remote. (Seldom used in tests, needed for an embedded 
Drillbit.)
    
    Are these semantics preserved with the present changes?


---

Reply via email to