Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/993#discussion_r145566366
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebSessionResources.java
---
@@ -68,16 +68,19 @@ public SocketAddress getRemoteAddress() {
@Override
public void close() {
-
try {
AutoCloseables.close(webUserSession, allocator);
} catch (Exception ex) {
logger.error("Failure while closing the session resources", ex);
}
- // Set the close future associated with this session.
+ // Notify all the listeners of this closeFuture for failure events so
that listeners can do cleanup related to this
+ // WebSession. This will be called after every query execution by
AnonymousWebUserConnection::cleanupSession and
--- End diff --
From my understanding session is tied to a cookie not a connection. In case
of anonymous session, we call close after completion of each query. But for
authenticated session the close will be called when HttpSession is invalidated
which is during logout or session timeout.
---
